aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorVolker Diels-Grabsch <v@njh.eu>2025-09-16 21:21:14 +0200
committerStefano Brivio <sbrivio@redhat.com>2025-09-17 13:51:24 +0200
commit142b3d872b7cd58391f59fa34f6ed399e72aaaf9 (patch)
tree533eda0142708e6bd1969b2ff444c669df429c40
parent07cb07de4c6e69beb9d15f9a0156e55c4ca6161a (diff)
downloadpasst-142b3d872b7cd58391f59fa34f6ed399e72aaaf9.tar
passt-142b3d872b7cd58391f59fa34f6ed399e72aaaf9.tar.gz
passt-142b3d872b7cd58391f59fa34f6ed399e72aaaf9.tar.bz2
passt-142b3d872b7cd58391f59fa34f6ed399e72aaaf9.tar.lz
passt-142b3d872b7cd58391f59fa34f6ed399e72aaaf9.tar.xz
passt-142b3d872b7cd58391f59fa34f6ed399e72aaaf9.tar.zst
passt-142b3d872b7cd58391f59fa34f6ed399e72aaaf9.zip
Fix --no-icmp description and make it imply --no-ndp
Signed-off-by: Volker Diels-Grabsch <v@njh.eu> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--conf.c3
-rw-r--r--passt.14
2 files changed, 5 insertions, 2 deletions
diff --git a/conf.c b/conf.c
index f47f48e..02e903b 100644
--- a/conf.c
+++ b/conf.c
@@ -2067,6 +2067,9 @@ void conf(struct ctx *c, int argc, char **argv)
isolate_user(uid, gid, !netns_only, userns, c->mode);
+ if (c->no_icmp)
+ c->no_ndp = 1;
+
if (c->pasta_conf_ns)
c->no_ra = 1;
diff --git a/passt.1 b/passt.1
index cef98b2..dd00b08 100644
--- a/passt.1
+++ b/passt.1
@@ -319,8 +319,8 @@ silently dropped.
.TP
.BR \-\-no-icmp
-Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests coming from
-guest or target namespace will be silently dropped.
+Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests coming from
+guest or target namespace will be silently dropped. Implies \fB--no-ndp\fR.
.TP
.BR \-\-no-dhcp