From 142b3d872b7cd58391f59fa34f6ed399e72aaaf9 Mon Sep 17 00:00:00 2001 From: Volker Diels-Grabsch Date: Tue, 16 Sep 2025 21:21:14 +0200 Subject: Fix --no-icmp description and make it imply --no-ndp Signed-off-by: Volker Diels-Grabsch Reviewed-by: David Gibson Signed-off-by: Stefano Brivio --- conf.c | 3 +++ passt.1 | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/conf.c b/conf.c index f47f48e..02e903b 100644 --- a/conf.c +++ b/conf.c @@ -2067,6 +2067,9 @@ void conf(struct ctx *c, int argc, char **argv) isolate_user(uid, gid, !netns_only, userns, c->mode); + if (c->no_icmp) + c->no_ndp = 1; + if (c->pasta_conf_ns) c->no_ra = 1; diff --git a/passt.1 b/passt.1 index cef98b2..dd00b08 100644 --- a/passt.1 +++ b/passt.1 @@ -319,8 +319,8 @@ silently dropped. .TP .BR \-\-no-icmp -Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests coming from -guest or target namespace will be silently dropped. +Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests coming from +guest or target namespace will be silently dropped. Implies \fB--no-ndp\fR. .TP .BR \-\-no-dhcp -- cgit v1.2.3