aboutgitcodebugslistschat
path: root/udp.h
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2023-08-22 15:29:57 +1000
committerStefano Brivio <sbrivio@redhat.com>2023-08-22 12:15:33 +0200
commit955dd3251c9e9b0a1469015748e4600f68e8de0a (patch)
treecf8a69238316c2e8a526f77b8faad6873c7c7cfe /udp.h
parent5bf200ae8a1ab298cb393bf1956599d1178567cb (diff)
downloadpasst-955dd3251c9e9b0a1469015748e4600f68e8de0a.tar
passt-955dd3251c9e9b0a1469015748e4600f68e8de0a.tar.gz
passt-955dd3251c9e9b0a1469015748e4600f68e8de0a.tar.bz2
passt-955dd3251c9e9b0a1469015748e4600f68e8de0a.tar.lz
passt-955dd3251c9e9b0a1469015748e4600f68e8de0a.tar.xz
passt-955dd3251c9e9b0a1469015748e4600f68e8de0a.tar.zst
passt-955dd3251c9e9b0a1469015748e4600f68e8de0a.zip
tcp, udp: Don't pre-fill IPv4 destination address in headers
Because packets sent on the tap interface will always be going to the guest/namespace, we more-or-less know what address they'll be going to. So we pre-fill this destination address in our header buffers for IPv4. We can't do the same for IPv6 because we could need either the global or link-local address for the guest. In future we're going to want more flexibility for the destination address, so this pre-filling will get in the way. Change the flow so we always fill in the IPv4 destination address for each packet, rather than prefilling it from proto_update_l2_buf(). In fact for TCP we already redundantly filled the destination for each packet anyway. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'udp.h')
-rw-r--r--udp.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/udp.h b/udp.h
index f9d4459..f553de2 100644
--- a/udp.h
+++ b/udp.h
@@ -16,8 +16,7 @@ int udp_sock_init(const struct ctx *c, int ns, sa_family_t af,
const void *addr, const char *ifname, in_port_t port);
int udp_init(struct ctx *c);
void udp_timer(struct ctx *c, const struct timespec *ts);
-void udp_update_l2_buf(const unsigned char *eth_d, const unsigned char *eth_s,
- const struct in_addr *ip_da);
+void udp_update_l2_buf(const unsigned char *eth_d, const unsigned char *eth_s);
/**
* union udp_epoll_ref - epoll reference portion for TCP connections