aboutgitcodebugslistschat
path: root/udp.h
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2022-11-04 14:10:35 +1100
committerStefano Brivio <sbrivio@redhat.com>2022-11-04 12:04:24 +0100
commit7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf (patch)
tree2cf45b6d9019e785f3c1c20bfee84576c46501a4 /udp.h
parentdd3470d9a92bd2fc83b3afd5ff9490b73de6a58c (diff)
downloadpasst-7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf.tar
passt-7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf.tar.gz
passt-7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf.tar.bz2
passt-7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf.tar.lz
passt-7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf.tar.xz
passt-7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf.tar.zst
passt-7c7b68dbe02874324e4fcda9c13b9e8d9a8192cf.zip
Use typing to reduce chances of IPv4 endianness errors
We recently corrected some errors handling the endianness of IPv4 addresses. These are very easy errors to make since although we mostly store them in network endianness, we sometimes need to manipulate them in host endianness. To reduce the chances of making such mistakes again, change to always using a (struct in_addr) instead of a bare in_addr_t or uint32_t to store network endian addresses. This makes it harder to accidentally do arithmetic or comparisons on such addresses as if they were host endian. We introduce a number of IN4_IS_ADDR_*() helpers to make it easier to directly work with struct in_addr values. This has the additional benefit of making the IPv4 and IPv6 paths more visually similar. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'udp.h')
-rw-r--r--udp.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/udp.h b/udp.h
index b4ee8b7..2ac8610 100644
--- a/udp.h
+++ b/udp.h
@@ -17,7 +17,7 @@ void udp_sock_init(const struct ctx *c, int ns, sa_family_t af,
int udp_init(struct ctx *c);
void udp_timer(struct ctx *c, const struct timespec *ts);
void udp_update_l2_buf(const unsigned char *eth_d, const unsigned char *eth_s,
- const uint32_t *ip_da);
+ const struct in_addr *ip_da);
/**
* union udp_epoll_ref - epoll reference portion for TCP connections