diff options
| author | Stefano Brivio <sbrivio@redhat.com> | 2025-12-08 22:18:01 +0100 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2025-12-09 01:27:24 +0100 |
| commit | c3f1ba70237a9e66822aff3aa5765d0adf6f6307 (patch) | |
| tree | d65e18061546fcabe5d56eb35910f633a2145f44 /test | |
| parent | e8b56a3d2456a62eed5ce4297134b26427c2e5b6 (diff) | |
| download | passt-c3f1ba70237a9e66822aff3aa5765d0adf6f6307.tar passt-c3f1ba70237a9e66822aff3aa5765d0adf6f6307.tar.gz passt-c3f1ba70237a9e66822aff3aa5765d0adf6f6307.tar.bz2 passt-c3f1ba70237a9e66822aff3aa5765d0adf6f6307.tar.lz passt-c3f1ba70237a9e66822aff3aa5765d0adf6f6307.tar.xz passt-c3f1ba70237a9e66822aff3aa5765d0adf6f6307.tar.zst passt-c3f1ba70237a9e66822aff3aa5765d0adf6f6307.zip | |
tcp_splice, flow: Add socket to epoll set before connect(), drop assert2025_12_09.c3f1ba7
...otherwise, if we have a real error on connect() (that is, not
EINPROGRESS), we'll return early from tcp_splice_connect() and later
try to fetch the epoll file descriptor:
ASSERTION FAILED in flow_epollfd (flow.c:362): f->epollid < ((1 << 8) - 1)
which is still (correctly) EPOLLFD_ID_INVALID.
Replace the ASSERT() in flow_epollfd() with a warning, as it looks
like there might be harmless cases where the socket is not in the
epoll set yet, and we'll just crash for nothing. We can turn this back
to an ASSERT() once we audit these paths in more detail.
Link: https://bodhi.fedoraproject.org/updates/FEDORA-2025-93b4eb64c3#comment-4473411
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions