diff options
| author | Cole Robinson <crobinso@redhat.com> | 2025-10-08 11:01:33 -0400 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2025-10-09 10:11:27 +0200 |
| commit | 5da0316f27c9b36b7ee4ba181d38a8dc358b2328 (patch) | |
| tree | e002bd06663a1cb5edca8e1a95a20f5927c39281 /test/lib | |
| parent | 518d8c1ef71bb9a6f38b4e83a0c97374882e4213 (diff) | |
| download | passt-5da0316f27c9b36b7ee4ba181d38a8dc358b2328.tar passt-5da0316f27c9b36b7ee4ba181d38a8dc358b2328.tar.gz passt-5da0316f27c9b36b7ee4ba181d38a8dc358b2328.tar.bz2 passt-5da0316f27c9b36b7ee4ba181d38a8dc358b2328.tar.lz passt-5da0316f27c9b36b7ee4ba181d38a8dc358b2328.tar.xz passt-5da0316f27c9b36b7ee4ba181d38a8dc358b2328.tar.zst passt-5da0316f27c9b36b7ee4ba181d38a8dc358b2328.zip | |
isolation: keep CAP_DAC_OVERRIDE initially
Reproducer that I'd expect to work:
$ cd $HOME
$ sudo passt --runas $UID --socket foo.sock
Failed to bind UNIX domain socket: Permission denied
A more practical example is for libguestfs apps when run as user=root:
+ libguestfs connects to libvirt qemu:///system
+ libvirt qemu:///system defaults to user=qemu
+ libvirt chowns /run/libvirt/qemu/passt dir to user=qemu
+ libguestfs instead requests the VM run as user=root
+ patches in progress but we are blocked by this issue
+ passt is launched as root, but because CAP_DAC_OVERRIDE has been
dropped, passt fails to create socket in qemu owned
/run/libvirt/qemu/passt
Fix it by not dropping CAP_DAC_OVERRIDE in isolate_initial.
This might look sketchy, but isolate_initial already keeps
CAP_SYS_ADMIN and CAP_NET_ADMIN, so we are probably no worse off.
Link: https://github.com/libguestfs/libguestfs/pull/218
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'test/lib')
0 files changed, 0 insertions, 0 deletions
