diff options
author | Stefano Brivio <sbrivio@redhat.com> | 2024-11-07 17:47:08 +0100 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2024-11-08 08:24:11 +0100 |
commit | 5f5e814cfc27c14cd7f116c8fb59e17d5671cafe (patch) | |
tree | 6a878e4e7b9b87cb9aaa5c1f604adc523ecf4c82 /tcp_vu.c | |
parent | 78da088f7babfa0431c6fb2704ef0709fe057770 (diff) | |
download | passt-5f5e814cfc27c14cd7f116c8fb59e17d5671cafe.tar passt-5f5e814cfc27c14cd7f116c8fb59e17d5671cafe.tar.gz passt-5f5e814cfc27c14cd7f116c8fb59e17d5671cafe.tar.bz2 passt-5f5e814cfc27c14cd7f116c8fb59e17d5671cafe.tar.lz passt-5f5e814cfc27c14cd7f116c8fb59e17d5671cafe.tar.xz passt-5f5e814cfc27c14cd7f116c8fb59e17d5671cafe.tar.zst passt-5f5e814cfc27c14cd7f116c8fb59e17d5671cafe.zip |
dhcpv6: Use for loop instead of goto to avoid false positive cppcheck warning
cppcheck 2.16.0 reports:
dhcpv6.c:334:14: style: The comparison 'ia_type == 3' is always true. [knownConditionTrueFalse]
if (ia_type == OPT_IA_NA) {
^
dhcpv6.c:306:12: note: 'ia_type' is assigned value '3' here.
ia_type = OPT_IA_NA;
^
dhcpv6.c:334:14: note: The comparison 'ia_type == 3' is always true.
if (ia_type == OPT_IA_NA) {
^
this is not really the case as we set ia_type to OPT_IA_TA and then
jump back.
Anyway, there's no particular reason to use a goto here: add a trivial
foreach() macro to go through elements of an array and use it instead.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'tcp_vu.c')
0 files changed, 0 insertions, 0 deletions