diff options
| author | Laine Stump <laine@redhat.com> | 2023-02-15 03:24:31 -0500 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2023-02-16 17:32:07 +0100 |
| commit | c864c6004715ce77d938c968274915b2ef481caa (patch) | |
| tree | 2a1d3065fb6362a8f58f9386edb68f419649726c /tcp.c | |
| parent | dac4af81e3cb0a3307d737812ec6a9d830eaf31d (diff) | |
| download | passt-c864c6004715ce77d938c968274915b2ef481caa.tar passt-c864c6004715ce77d938c968274915b2ef481caa.tar.gz passt-c864c6004715ce77d938c968274915b2ef481caa.tar.bz2 passt-c864c6004715ce77d938c968274915b2ef481caa.tar.lz passt-c864c6004715ce77d938c968274915b2ef481caa.tar.xz passt-c864c6004715ce77d938c968274915b2ef481caa.tar.zst passt-c864c6004715ce77d938c968274915b2ef481caa.zip | |
eliminate most calls to usage() in conf()
Nearly all of the calls to usage() in conf() occur immediately after
logging a more detailed error message, and the fact that these errors
are occuring indicates that the user has already seen the passt usage
message (or read the manpage). Spamming the logfile with the complete
contents of the usage message serves only to obscure the more detailed
error message. The only time when the full usage message should be output
is if the user explicitly asks for it with -h (or its synonyms)
As a start to eliminating the excessive calls to usage(), this patch
replaces most calls to err() followed by usage() with a call to die()
instead. A few other usage() calls remain, but their removal involves
bit more nuance that should be properly explained in separate commit
messages.
Signed-off-by: Laine Stump <laine@redhat.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'tcp.c')
0 files changed, 0 insertions, 0 deletions