aboutgitcodebugslistschat
path: root/pcap.h
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2024-08-06 20:32:11 +0200
committerStefano Brivio <sbrivio@redhat.com>2024-08-08 21:31:25 +0200
commit09603cab28f9883baf1d7b48bdc102d6641dc300 (patch)
tree3ff30ff534d70179735e8f39354db6e418cb4cf0 /pcap.h
parent755f9fd91125c65361c81d8aa9e8af2cfd7adc6d (diff)
downloadpasst-09603cab28f9883baf1d7b48bdc102d6641dc300.tar
passt-09603cab28f9883baf1d7b48bdc102d6641dc300.tar.gz
passt-09603cab28f9883baf1d7b48bdc102d6641dc300.tar.bz2
passt-09603cab28f9883baf1d7b48bdc102d6641dc300.tar.lz
passt-09603cab28f9883baf1d7b48bdc102d6641dc300.tar.xz
passt-09603cab28f9883baf1d7b48bdc102d6641dc300.tar.zst
passt-09603cab28f9883baf1d7b48bdc102d6641dc300.zip
passt, util: Close any open file that the parent might have leaked
If a parent accidentally or due to implementation reasons leaks any open file, we don't want to have access to them, except for the file passed via --fd, if any. This is the case for Podman when Podman's parent leaks files into Podman: it's not practical for Podman to close unrelated files before starting pasta, as reported by Paul. Use close_range(2) to close all open files except for standard streams and the one from --fd. Given that parts of conf() depend on other files to be already opened, such as the epoll file descriptor, we can't easily defer this to a more convenient point, where --fd was already parsed. Introduce a minimal, duplicate version of --fd parsing to keep this simple. As we need to check that the passed --fd option doesn't exceed INT_MAX, because we'll parse it with strtol() but file descriptor indices are signed ints (regardless of the arguments close_range() take), extend the existing check in the actual --fd parsing in conf(), also rejecting file descriptors numbers that match standard streams, while at it. Suggested-by: Paul Holzinger <pholzing@redhat.com> Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'pcap.h')
0 files changed, 0 insertions, 0 deletions