passt: Add clang-tidy Makefile target and test, take care of warnings

Most are just about style and form, but a few were actually
serious mistakes (NDP-related).

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/pasta.c b/pasta.c
index 395f459..3febfd5 100644
--- a/pasta.c
+++ b/pasta.c
@@ -204,7 +204,7 @@ void pasta_start_ns(struct ctx *c)
 		close(fd);
 
 		fd = open("/proc/self/setgroups", O_WRONLY);
-		if (write(fd, "deny", sizeof("deny")))
+		if (write(fd, "deny", sizeof("deny")) < 0)
 			warn("Cannot write to setgroups in namespace");
 		close(fd);