aboutgitcodebugslistschat
path: root/icmp.c
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2023-09-21 14:49:38 +1000
committerStefano Brivio <sbrivio@redhat.com>2023-09-27 17:25:51 +0200
commit5b6c68c2e4995b94110b62e9e8346fb372451e31 (patch)
tree5c10ec7a0a154598f24cd13bbc329805966e462b /icmp.c
parent9178a9e3462d7fb931e4316d99eccbb3e7460cb7 (diff)
downloadpasst-5b6c68c2e4995b94110b62e9e8346fb372451e31.tar
passt-5b6c68c2e4995b94110b62e9e8346fb372451e31.tar.gz
passt-5b6c68c2e4995b94110b62e9e8346fb372451e31.tar.bz2
passt-5b6c68c2e4995b94110b62e9e8346fb372451e31.tar.lz
passt-5b6c68c2e4995b94110b62e9e8346fb372451e31.tar.xz
passt-5b6c68c2e4995b94110b62e9e8346fb372451e31.tar.zst
passt-5b6c68c2e4995b94110b62e9e8346fb372451e31.zip
Avoid shadowing index(3)
A classic gotcha of the standard C library is that its unwise to call any variable 'index' because it will shadow the standard string library function index(3). This can cause warnings from cppcheck amongst others, and it also means that if the variable is removed you tend to get confusing type errors (or sometimes nothing at all) instead of a nice simple "name is not defined" error. Strictly speaking this only occurs if <string.h> is included, but that is so common that as a rule it's best to just avoid it always. We have a number of places which hit this trap, so rename variables and parameters to avoid it. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'icmp.c')
0 files changed, 0 insertions, 0 deletions