aboutgitcodebugslistschat
path: root/icmp.c
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2022-10-19 11:43:56 +1100
committerStefano Brivio <sbrivio@redhat.com>2022-10-19 03:34:56 +0200
commit2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca (patch)
treef1fb7ac47fed918dc0232df477cff46f0c5e9493 /icmp.c
parentdb07804d26fbd0d350d4d1c90dd9a43c5e4d9f93 (diff)
downloadpasst-2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca.tar
passt-2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca.tar.gz
passt-2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca.tar.bz2
passt-2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca.tar.lz
passt-2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca.tar.xz
passt-2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca.tar.zst
passt-2dbc622f547cc4d150c8c6a1b1ecaf47aba2baca.zip
tap: Split tap_ip4_send() into UDP and ICMP variants
tap_ip4_send() has special case logic to compute the checksums for UDP and ICMP packets, which is a mild layering violation. By using a suitable helper we can split it into tap_udp4_send() and tap_icmp4_send() functions without greatly increasing the code size, this removing that layering violation. We make some small changes to the interface while there. In both cases we make the destination IPv4 address a parameter, which will be useful later. For the UDP variant we make it take just the UDP payload, and it will generate the UDP header. For the ICMP variant we pass in the ICMP header as before. The inconsistency is because that's what seems to be the more natural way to invoke the function in the callers in each case. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'icmp.c')
-rw-r--r--icmp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/icmp.c b/icmp.c
index 6493ea9..233acf9 100644
--- a/icmp.c
+++ b/icmp.c
@@ -124,7 +124,8 @@ void icmp_sock_handler(const struct ctx *c, union epoll_ref ref,
icmp_id_map[V4][id].seq = seq;
}
- tap_ip4_send(c, sr4->sin_addr.s_addr, IPPROTO_ICMP, buf, n);
+ tap_icmp4_send(c, sr4->sin_addr.s_addr, tap_ip4_daddr(c),
+ buf, n);
}
}