Use typing to reduce chances of IPv4 endianness errors

We recently corrected some errors handling the endianness of IPv4
addresses.  These are very easy errors to make since although we mostly
store them in network endianness, we sometimes need to manipulate them in
host endianness.

To reduce the chances of making such mistakes again, change to always using
a (struct in_addr) instead of a bare in_addr_t or uint32_t to store network
endian addresses.  This makes it harder to accidentally do arithmetic or
comparisons on such addresses as if they were host endian.

We introduce a number of IN4_IS_ADDR_*() helpers to make it easier to
directly work with struct in_addr values.  This has the additional benefit
of making the IPv4 and IPv6 paths more visually similar.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

1 files changed, 1 insertions, 2 deletions

diff --git a/icmp.c b/icmp.c
index d388815..b842fa8 100644
--- a/icmp.c
+++ b/icmp.c
@@ -130,8 +130,7 @@ void icmp_sock_handler(const struct ctx *c, union epoll_ref ref,
 		debug("ICMP: echo %s to tap, ID: %i, seq: %i",
 		      (ih->type == ICMP_ECHO) ? "request" : "reply", id, seq);
 
-		tap_icmp4_send(c, sr4->sin_addr.s_addr, tap_ip4_daddr(c),
-			       buf, n);
+		tap_icmp4_send(c, sr4->sin_addr, tap_ip4_daddr(c), buf, n);
 	}
 }