aboutgitcodebugslistschat
path: root/icmp.c
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2021-04-23 22:22:37 +0200
committerStefano Brivio <sbrivio@redhat.com>2021-04-23 22:22:37 +0200
commit38b50dba4704856194ac02b98e492d2349d64058 (patch)
treeb7f7a12479aa53f9e7ac2cae7a4e709ce78d99a5 /icmp.c
parent962bc97cf116519bd11b7e8beeda6dcce033d537 (diff)
downloadpasst-38b50dba4704856194ac02b98e492d2349d64058.tar
passt-38b50dba4704856194ac02b98e492d2349d64058.tar.gz
passt-38b50dba4704856194ac02b98e492d2349d64058.tar.bz2
passt-38b50dba4704856194ac02b98e492d2349d64058.tar.lz
passt-38b50dba4704856194ac02b98e492d2349d64058.tar.xz
passt-38b50dba4704856194ac02b98e492d2349d64058.tar.zst
passt-38b50dba4704856194ac02b98e492d2349d64058.zip
passt: Spare some syscalls, add some optimisations from profiling
Avoid a bunch of syscalls on forwarding paths by: - storing minimum and maximum file descriptor numbers for each protocol, fall back to SO_PROTOCOL query only on overlaps - allocating a larger receive buffer -- this can result in more coalesced packets than sendmmsg() can take (UIO_MAXIOV, i.e. 1024), so make sure we don't exceed that within a single call to protocol tap handlers - nesting the handling loop in tap_handler() in the receive loop, so that we have better chances of filling our receive buffer in fewer calls - skipping the recvfrom() in the UDP handler on EPOLLERR -- there's nothing to be done in that case and while at it: - restore the 20ms timer interval for periodic (TCP) events, I accidentally changed that to 100ms in an earlier commit - attempt using SO_ZEROCOPY for UDP -- if it's not available, sendmmsg() will succeed anyway - fix the handling of the status code from sendmmsg(), if it fails, we'll try to discard the first message, hence return 1 from the UDP handler Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'icmp.c')
-rw-r--r--icmp.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/icmp.c b/icmp.c
index 9a3c740..dd4e3a4 100644
--- a/icmp.c
+++ b/icmp.c
@@ -135,6 +135,9 @@ int icmp_tap_handler(struct ctx *c, int af, void *addr,
*/
int icmp_sock_init(struct ctx *c)
{
+ c->icmp.fd_min = INT_MAX;
+ c->icmp.fd_max = 0;
+
if (c->v4 && (c->icmp.s4 = sock_l4_add(c, 4, IPPROTO_ICMP, 0)) < 0)
return -1;