tcp: MAX_WINDOW should be unsigned

Currently MAX_WINDOW is defined as a (signed) int, since '1' is a signed
literal.  This means that when it's used in the SEQ_*() macros, we're
making a signed / unsigned comparison.  While I don't think it was
incorrect in practice, confirming that requires reasoning though arcane
C type promotion rules.

Since it's obviously a non-negative value, change the constant to unsigned.
Change BUF_DISCARD_SIZE for the same reason, and because they're linked
via DISCARD_IOV_NUM, which must also be non-negative.  Change the types
of a few variables in tcp_prepare_iov() to match (otherwise we'd get some
compiler warnings).

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

0 files changed, 0 insertions, 0 deletions