aboutgitcodebugslistschat
path: root/dhcp.c
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2022-10-19 11:43:48 +1100
committerStefano Brivio <sbrivio@redhat.com>2022-10-19 03:34:34 +0200
commit3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40 (patch)
tree0ad716aa9183aca9ec8a88dc0b1e95bc9e470786 /dhcp.c
parentbd4be308fc92ed5d75ea45364a9f837d5c0fb0b2 (diff)
downloadpasst-3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40.tar
passt-3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40.tar.gz
passt-3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40.tar.bz2
passt-3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40.tar.lz
passt-3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40.tar.xz
passt-3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40.tar.zst
passt-3d8ccb44a6a3dc74b9bf7b765c7a2ae41f771d40.zip
Add csum_ip4_header() helper to calculate IPv4 header checksums
We calculate IPv4 header checksums in at least two places, in dhcp() and in tap_ip_send. Add a helper to handle this calculation in both places. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'dhcp.c')
-rw-r--r--dhcp.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/dhcp.c b/dhcp.c
index 8dcf645..875e18b 100644
--- a/dhcp.c
+++ b/dhcp.c
@@ -371,8 +371,7 @@ int dhcp(const struct ctx *c, const struct pool *p)
iph->tot_len = htons(len += sizeof(*iph));
iph->daddr = c->ip4.addr;
iph->saddr = c->ip4.gw;
- iph->check = 0;
- iph->check = csum_unaligned(iph, (intptr_t)(iph->ihl * 4), 0);
+ csum_ip4_header(iph);
len += sizeof(*eh);
memcpy(eh->h_dest, eh->h_source, ETH_ALEN);