diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2022-09-28 14:33:17 +1000 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2022-09-29 12:21:55 +0200 |
| commit | 7d4e50827c0681838793bf2ee81dbb6386c5db69 (patch) | |
| tree | beca090fe37d7fff3501af10f6105c6aaa8a04b9 /contrib | |
| parent | 8534be076c73603d58d54634b5d3e78bd5d96ec0 (diff) | |
| download | passt-7d4e50827c0681838793bf2ee81dbb6386c5db69.tar passt-7d4e50827c0681838793bf2ee81dbb6386c5db69.tar.gz passt-7d4e50827c0681838793bf2ee81dbb6386c5db69.tar.bz2 passt-7d4e50827c0681838793bf2ee81dbb6386c5db69.tar.lz passt-7d4e50827c0681838793bf2ee81dbb6386c5db69.tar.xz passt-7d4e50827c0681838793bf2ee81dbb6386c5db69.tar.zst passt-7d4e50827c0681838793bf2ee81dbb6386c5db69.zip | |
Pack DHCPv6 "on wire" structures
dhcpv6.c contains a number of structures which represent actual DHCPv6
packets as they appear on the wire, which will break if the structures
don't have exactly the in-memory layout we expect.
Therefore, we should mark these structures as ((packed)). The contents of
them means this is unlikely to change the layout in practice - and since
it was working, presumably didn't on any arch we were testing on. However
it's not impossible for the compiler on some arch to insert unexpected
padding in one of these structures, so we should be explicit.
clang-tidy warned about this since we were using memcmp() to compare some
of these structures, which it thought might not have a unique
representation.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions