diff options
| author | Stefano Brivio <sbrivio@redhat.com> | 2021-10-21 09:41:13 +0200 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2021-10-21 09:41:13 +0200 |
| commit | 627e18fa8ad000ed92405cff3a88c36fd5f3027e (patch) | |
| tree | 5caf72002139dd6bc80cd424de1730f8602cbb9d /conf.c | |
| parent | c3f8e4d2cd55e57419478ff849265d1e342e7990 (diff) | |
| download | passt-627e18fa8ad000ed92405cff3a88c36fd5f3027e.tar passt-627e18fa8ad000ed92405cff3a88c36fd5f3027e.tar.gz passt-627e18fa8ad000ed92405cff3a88c36fd5f3027e.tar.bz2 passt-627e18fa8ad000ed92405cff3a88c36fd5f3027e.tar.lz passt-627e18fa8ad000ed92405cff3a88c36fd5f3027e.tar.xz passt-627e18fa8ad000ed92405cff3a88c36fd5f3027e.tar.zst passt-627e18fa8ad000ed92405cff3a88c36fd5f3027e.zip | |
passt: Add cppcheck target, test, and address resulting warnings
...mostly false positives, but a number of very relevant ones too,
in tcp_get_sndbuf(), tcp_conn_from_tap(), and siphash PREAMBLE().
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'conf.c')
| -rw-r--r-- | conf.c | 6 |
1 files changed, 4 insertions, 2 deletions
@@ -678,7 +678,7 @@ pasta_opts: void conf_print(struct ctx *c) { - char buf6[INET6_ADDRSTRLEN], buf4[INET_ADDRSTRLEN], ifn[IFNAMSIZ]; + char buf4[INET_ADDRSTRLEN], ifn[IFNAMSIZ]; int i; if (c->mode == MODE_PASTA) { @@ -723,6 +723,8 @@ void conf_print(struct ctx *c) } if (c->v6) { + char buf6[INET6_ADDRSTRLEN]; + if (!c->no_ndp && !c->no_dhcpv6) info("NDP/DHCPv6:"); else if (!c->no_ndp) @@ -1013,7 +1015,7 @@ void conf(struct ctx *c, int argc, char **argv) errno = 0; mask = strtol(optarg, NULL, 0); - if (mask >= 0 && mask <= 32 && !errno) { + if (mask > 0 && mask <= 32 && !errno) { c->mask4 = htonl(0xffffffff << (32 - mask)); break; } |