aboutgitcodebugslistschat
path: root/conf.c
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2022-09-19 22:15:04 +0200
committerStefano Brivio <sbrivio@redhat.com>2022-09-22 16:54:09 +0200
commit4a1b67527862c687f523470bda441a954d00a9af (patch)
treec52df22893fa42f3a82f0b49dda21a5806a38343 /conf.c
parentd30bde3181a3d3aac406a15fd6c905612c8e416c (diff)
downloadpasst-4a1b67527862c687f523470bda441a954d00a9af.tar
passt-4a1b67527862c687f523470bda441a954d00a9af.tar.gz
passt-4a1b67527862c687f523470bda441a954d00a9af.tar.bz2
passt-4a1b67527862c687f523470bda441a954d00a9af.tar.lz
passt-4a1b67527862c687f523470bda441a954d00a9af.tar.xz
passt-4a1b67527862c687f523470bda441a954d00a9af.tar.zst
passt-4a1b67527862c687f523470bda441a954d00a9af.zip
conf, tcp, udp: Arrays for ports need 2^16 values, not 2^16-8
Reported by David but also by Coverity (CWE-119): In conf_ports: Out-of-bounds access to a buffer ...not in practice, because the allocation size is rounded up anyway, but not nice either. Reported-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'conf.c')
-rw-r--r--conf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/conf.c b/conf.c
index d80233c..7ecfa1e 100644
--- a/conf.c
+++ b/conf.c
@@ -127,8 +127,8 @@ static int conf_ports(struct ctx *c, char optname, const char *optarg,
{
int start_src, end_src, start_dst, end_dst, exclude_only = 1, i, port;
char addr_buf[sizeof(struct in6_addr)] = { 0 }, *addr = addr_buf;
+ uint8_t *map, exclude[DIV_ROUND_UP(USHRT_MAX, 8)] = { 0 };
void (*remap)(in_port_t port, in_port_t delta);
- uint8_t *map, exclude[USHRT_MAX / 8] = { 0 };
char buf[BUFSIZ], *sep, *spec, *p;
sa_family_t af = AF_UNSPEC;