diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2026-07-03 13:54:33 +1000 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2026-07-04 13:13:50 +0200 |
| commit | e51a545f3b68b60c1488a13061fec54e01236e47 (patch) | |
| tree | 487526814a49595d728132c6974dec53ff15f1ac | |
| parent | edeb2a26c663085b3eae0a7eac6eb011a21ae7c3 (diff) | |
| download | passt-e51a545f3b68b60c1488a13061fec54e01236e47.tar passt-e51a545f3b68b60c1488a13061fec54e01236e47.tar.gz passt-e51a545f3b68b60c1488a13061fec54e01236e47.tar.bz2 passt-e51a545f3b68b60c1488a13061fec54e01236e47.tar.lz passt-e51a545f3b68b60c1488a13061fec54e01236e47.tar.xz passt-e51a545f3b68b60c1488a13061fec54e01236e47.tar.zst passt-e51a545f3b68b60c1488a13061fec54e01236e47.zip | |
Makefile: Add missing PESTO_HEADERS variable
In several places we use a PESTO_HEADERS variable, with all the headers
that we need to build the pesto binary. However, we never define it.
This looks like an error introduced by a bad rebase of the series
introducing pesto before it was merged.
It turns out the fact we didn't list the headers was the only reason we
weren't getting unusedStructMember cppcheck warnings for pesto as we
already do for passt and passt-repair. So, reinstate that suppression for
pesto as well.
Fixes: 02236db32625 ("pesto: Introduce stub configuration tool")
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
| -rw-r--r-- | Makefile | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -55,6 +55,7 @@ PASST_HEADERS = arch.h arp.h bitmap.h checksum.h conf.h dhcp.h dhcpv6.h \ virtio.h vu_common.h QRAP_HEADERS = arp.h ip.h passt.h util.h PASST_REPAIR_HEADERS = linux_dep.h +PESTO_HEADERS = bitmap.h common.h fwd_rule.h inany.h ip.h log.h pesto.h serialise.h C := \#include <sys/random.h>\nint main(){int a=getrandom(0, 0, 0);} ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) @@ -203,7 +204,8 @@ CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ else \ echo ""; \ fi) \ - --suppress=missingIncludeSystem + --suppress=missingIncludeSystem \ + --suppress=unusedStructMember cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck @@ -212,10 +214,8 @@ cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^ passt.cppcheck: BASE_CPPFLAGS += -UPESTO -passt.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt.cppcheck: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h -passt-repair.cppcheck: CPPCHECK_FLAGS += --suppress=unusedStructMember passt-repair.cppcheck: $(PASST_REPAIR_SRCS) $(PASST_REPAIR_HEADERS) seccomp_repair.h pesto.cppcheck: BASE_CPPFLAGS += -DPESTO |