aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2023-01-06 11:43:15 +1100
committerStefano Brivio <sbrivio@redhat.com>2023-01-23 18:54:47 +0100
commitdcea26076ded89ff66da8046b12052045a51de0f (patch)
tree688e5cc7b2bec102d3d09c7d9f3e050dbc170377
parent716a926ef485602d3e5aafd93ed5893d1eca39b6 (diff)
downloadpasst-dcea26076ded89ff66da8046b12052045a51de0f.tar
passt-dcea26076ded89ff66da8046b12052045a51de0f.tar.gz
passt-dcea26076ded89ff66da8046b12052045a51de0f.tar.bz2
passt-dcea26076ded89ff66da8046b12052045a51de0f.tar.lz
passt-dcea26076ded89ff66da8046b12052045a51de0f.tar.xz
passt-dcea26076ded89ff66da8046b12052045a51de0f.tar.zst
passt-dcea26076ded89ff66da8046b12052045a51de0f.zip
tcp: Remove redundant and incorrect initialization from *_iov_init()
tcp_sock[46]_iov_init() initialize the length of each iovec buffer to MSS_DEFAULT. That will always be overwritten before use in tcp_data_to_tap, so it's redundant. It also wasn't correct, because it didn't correctly account for the header lengths in all cases. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--tcp.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/tcp.c b/tcp.c
index ccb5895..052e38f 100644
--- a/tcp.c
+++ b/tcp.c
@@ -1072,10 +1072,8 @@ static void tcp_sock4_iov_init(void)
};
}
- for (i = 0, iov = tcp4_l2_iov; i < TCP_FRAMES_MEM; i++, iov++) {
+ for (i = 0, iov = tcp4_l2_iov; i < TCP_FRAMES_MEM; i++, iov++)
iov->iov_base = &tcp4_l2_buf[i].vnet_len;
- iov->iov_len = MSS_DEFAULT;
- }
for (i = 0, iov = tcp4_l2_flags_iov; i < TCP_FRAMES_MEM; i++, iov++)
iov->iov_base = &tcp4_l2_flags_buf[i].vnet_len;
@@ -1104,10 +1102,8 @@ static void tcp_sock6_iov_init(void)
};
}
- for (i = 0, iov = tcp6_l2_iov; i < TCP_FRAMES_MEM; i++, iov++) {
+ for (i = 0, iov = tcp6_l2_iov; i < TCP_FRAMES_MEM; i++, iov++)
iov->iov_base = &tcp6_l2_buf[i].vnet_len;
- iov->iov_len = MSS_DEFAULT;
- }
for (i = 0, iov = tcp6_l2_flags_iov; i < TCP_FRAMES_MEM; i++, iov++)
iov->iov_base = &tcp6_l2_flags_buf[i].vnet_len;