aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2023-08-23 17:03:38 +1000
committerStefano Brivio <sbrivio@redhat.com>2023-08-23 15:52:31 +0200
commita7e4bfb857cb5d0e111ab74b6ace47eea15d2078 (patch)
tree853f26a181c631d116cd1985ecf2fd61563e19b0
parent5e4f7b92b0b0bf4724c505fa95fcae1526a8f88b (diff)
downloadpasst-a7e4bfb857cb5d0e111ab74b6ace47eea15d2078.tar
passt-a7e4bfb857cb5d0e111ab74b6ace47eea15d2078.tar.gz
passt-a7e4bfb857cb5d0e111ab74b6ace47eea15d2078.tar.bz2
passt-a7e4bfb857cb5d0e111ab74b6ace47eea15d2078.tar.lz
passt-a7e4bfb857cb5d0e111ab74b6ace47eea15d2078.tar.xz
passt-a7e4bfb857cb5d0e111ab74b6ace47eea15d2078.tar.zst
passt-a7e4bfb857cb5d0e111ab74b6ace47eea15d2078.zip
pasta: Strip RTA_PREFSRC when copying routes to the namespace2023_08_23.a7e4bfb
Host routes can include a preferred source address (RTA_PREFSRC), which must be one of the host's addresses. However when using pasta with -a the namespace might be given a different address, not on the host. This seems to occur pretty routinely depending on the network configuration systems in place on the host. With --config-net we will try to copy host routes to the namespace. If one of those includes an RTA_PREFSRC, but the namespace doesn't have the host address, this will fail with -EINVAL, causing pasta to fail. Fix this by stripping off RTA_PREFSRC attributes from routes as we copy them to the namespace. This is by no means infallible, bit it should at least handle common cases for the time being. Link: https://bugs.passt.top/show_bug.cgi?id=71 Link: https://github.com/containers/podman/pull/19699#issuecomment-1688769287 Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--netlink.c15
1 files changed, 14 insertions, 1 deletions
diff --git a/netlink.c b/netlink.c
index 7e9caf4..6c57a68 100644
--- a/netlink.c
+++ b/netlink.c
@@ -462,8 +462,21 @@ int nl_route_dup(int s_src, unsigned int ifi_src,
for (rta = RTM_RTA(rtm), na = RTM_PAYLOAD(nh); RTA_OK(rta, na);
rta = RTA_NEXT(rta, na)) {
- if (rta->rta_type == RTA_OIF)
+ if (rta->rta_type == RTA_OIF) {
+ /* The host obviously list's the host interface
+ * id here, we need to change it to the
+ * namespace's interface id
+ */
*(unsigned int *)RTA_DATA(rta) = ifi_dst;
+ } else if (rta->rta_type == RTA_PREFSRC) {
+ /* Host routes might include a preferred source
+ * address, which must be one of the host's
+ * addresses. However, with -a pasta will use a
+ * different namespace address, making such a
+ * route invalid in the namespace. Strip off
+ * RTA_PREFSRC attributes to avoid that. */
+ rta->rta_type = RTA_UNSPEC;
+ }
}
}