aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2023-02-27 03:05:26 +0100
committerStefano Brivio <sbrivio@redhat.com>2023-02-27 18:55:10 +0100
commita1d5537741679c117b4c1a9b736ea2540a976eee (patch)
tree7505bb36f600fc65b35688cf5c8c9036df5dedad
parent5474bc5485d814acae19961f9a9cd4b541722a5e (diff)
downloadpasst-a1d5537741679c117b4c1a9b736ea2540a976eee.tar
passt-a1d5537741679c117b4c1a9b736ea2540a976eee.tar.gz
passt-a1d5537741679c117b4c1a9b736ea2540a976eee.tar.bz2
passt-a1d5537741679c117b4c1a9b736ea2540a976eee.tar.lz
passt-a1d5537741679c117b4c1a9b736ea2540a976eee.tar.xz
passt-a1d5537741679c117b4c1a9b736ea2540a976eee.tar.zst
passt-a1d5537741679c117b4c1a9b736ea2540a976eee.zip
tcp: Avoid false (but convoluted) positive Coverity CWE-476 warning
If there are no TCP options in the header, tcp_tap_handler() will pass the corresponding pointer, fetched via packet_get(), as NULL to tcp_conn_from_sock_finish(), which in turn indirectly calls tcp_opt_get(). If there are no options, tcp_opt_get() will stop right away because the option length is indicated as zero. However, if the logic is complicated enough to follow for static checkers, adding an explicit check against NULL in tcp_opt_get() is probably a good idea. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--tcp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tcp.c b/tcp.c
index 41210a3..561064e 100644
--- a/tcp.c
+++ b/tcp.c
@@ -1114,7 +1114,7 @@ static int tcp_opt_get(const char *opts, size_t len, uint8_t type_find,
{
uint8_t type, optlen;
- if (!len)
+ if (!opts || !len)
return -1;
for (; len >= 2; opts += optlen, len -= optlen) {