aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2022-10-26 17:01:12 +0200
committerStefano Brivio <sbrivio@redhat.com>2022-10-27 00:18:16 +0200
commit947d756747bfe938d95c3cbc163d148b54e03d68 (patch)
treeae6376009164b65c2f1bd540d56d1fb02c4d0311
parent74029516585dd78cc780e135a8c29d545e7e790e (diff)
downloadpasst-947d756747bfe938d95c3cbc163d148b54e03d68.tar
passt-947d756747bfe938d95c3cbc163d148b54e03d68.tar.gz
passt-947d756747bfe938d95c3cbc163d148b54e03d68.tar.bz2
passt-947d756747bfe938d95c3cbc163d148b54e03d68.tar.lz
passt-947d756747bfe938d95c3cbc163d148b54e03d68.tar.xz
passt-947d756747bfe938d95c3cbc163d148b54e03d68.tar.zst
passt-947d756747bfe938d95c3cbc163d148b54e03d68.zip
tap: Trace received (outbound) ICMP packets in debug mode, too
This only worked for ICMPv6: ICMP packets have no TCP-style header, so they are handled as a special case before packet sequences are formed, and the call to tap_packet_debug() was missing. Fixes: bb708111833e ("treewide: Packet abstraction with mandatory boundary checks") Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--tap.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/tap.c b/tap.c
index 3f78c99..4dcff4f 100644
--- a/tap.c
+++ b/tap.c
@@ -463,6 +463,8 @@ resume:
if (c->no_icmp)
continue;
+ tap_packet_debug(iph, NULL, NULL, 0, NULL, 1);
+
packet_add(pkt, l4_len, l4h);
icmp_tap_handler(c, AF_INET, &iph->daddr, pkt, now);
continue;