aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2022-09-28 14:33:31 +1000
committerStefano Brivio <sbrivio@redhat.com>2022-09-29 12:22:30 +0200
commit8f6be016aeacabd9a83d04b123e6bda898196ea2 (patch)
tree34963c8d7b83577a77ead2e0a95ac8c7d398a797
parent740ea28f29bb85fafccac81d2c13c2970a0d82b7 (diff)
downloadpasst-8f6be016aeacabd9a83d04b123e6bda898196ea2.tar
passt-8f6be016aeacabd9a83d04b123e6bda898196ea2.tar.gz
passt-8f6be016aeacabd9a83d04b123e6bda898196ea2.tar.bz2
passt-8f6be016aeacabd9a83d04b123e6bda898196ea2.tar.lz
passt-8f6be016aeacabd9a83d04b123e6bda898196ea2.tar.xz
passt-8f6be016aeacabd9a83d04b123e6bda898196ea2.tar.zst
passt-8f6be016aeacabd9a83d04b123e6bda898196ea2.zip
cppcheck: Suppress same-value-in-ternary branches warning
TIMER_INTERVAL is the minimum of two separately defined intervals which happen to have the same value at present. This results in an expression which has the same value in both branches of a ternary operator, which cppcheck warngs about. This is logically sound in this case, so suppress the error (we appear to already have a similar suppression for clang-tidy). Also add an unmatchedSuppression suppression, since only some cppcheck versions complain about this instance. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--passt.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/passt.c b/passt.c
index 4796c89..2c4a986 100644
--- a/passt.c
+++ b/passt.c
@@ -305,6 +305,7 @@ int main(int argc, char **argv)
loop:
/* NOLINTNEXTLINE(bugprone-branch-clone): intervals can be the same */
+ /* cppcheck-suppress [duplicateValueTernary, unmatchedSuppression] */
nfds = epoll_wait(c.epollfd, events, EPOLL_EVENTS, TIMER_INTERVAL);
if (nfds == -1 && errno != EINTR) {
perror("epoll_wait");