diff options
author | Stefano Brivio <sbrivio@redhat.com> | 2024-11-27 15:37:01 +0100 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2024-11-27 16:49:21 +0100 |
commit | 804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6 (patch) | |
tree | 043879c3b9828fc602d7af2dace9b65df8d83759 | |
parent | 00cc2303fd6ac4b72c19d1741dff72fd42c09a47 (diff) | |
download | passt-804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6.tar passt-804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6.tar.gz passt-804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6.tar.bz2 passt-804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6.tar.lz passt-804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6.tar.xz passt-804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6.tar.zst passt-804a7ce94a14fbc4dee0a14b2c5f7a72ebb8bff6.zip |
tcp_vu: Change 'dlen' to ssize_t in tcp_vu_data_from_sock()
...to quickly suppress a false positive from Coverity, which assumes
that iov_size is 0 and 'dlen' might overflow as a result (with hdrlen
being 66). An ASSERT() in tcp_vu_sock_recv() already guarantees that
iov_size(iov, buf_cnt) here is anyway greater than 'hdrlen'.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
-rw-r--r-- | tcp_vu.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -463,7 +463,7 @@ int tcp_vu_data_from_sock(const struct ctx *c, struct tcp_tap_conn *conn) for (i = 0, check = NULL; i < head_cnt; i++) { struct iovec *iov = &elem[head[i]].in_sg[0]; int buf_cnt = head[i + 1] - head[i]; - int dlen = iov_size(iov, buf_cnt) - hdrlen; + ssize_t dlen = iov_size(iov, buf_cnt) - hdrlen; vu_set_vnethdr(vdev, iov->iov_base, buf_cnt); |