aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2024-11-07 19:28:21 +0100
committerStefano Brivio <sbrivio@redhat.com>2024-11-08 08:24:52 +0100
commit71869e2912b9ede9532725e9ee5e7752b7137009 (patch)
tree428830857b51b6ede815c5dcace9fdeec4d2ae8d
parentd4f09c9b96c68a1c6b1387cd5674cd331a939f27 (diff)
downloadpasst-71869e2912b9ede9532725e9ee5e7752b7137009.tar
passt-71869e2912b9ede9532725e9ee5e7752b7137009.tar.gz
passt-71869e2912b9ede9532725e9ee5e7752b7137009.tar.bz2
passt-71869e2912b9ede9532725e9ee5e7752b7137009.tar.lz
passt-71869e2912b9ede9532725e9ee5e7752b7137009.tar.xz
passt-71869e2912b9ede9532725e9ee5e7752b7137009.tar.zst
passt-71869e2912b9ede9532725e9ee5e7752b7137009.zip
passt: Use NOLINT clang-tidy block instead of NOLINTNEXTLINE
For some reason, this is only reported by clang-tidy 19.1.2 on Alpine: /home/sbrivio/passt/passt.c:314:53: error: conditional operator with identical true and false expressions [bugprone-branch-clone,-warnings-as-errors] 314 | nfds = epoll_wait(c.epollfd, events, EPOLL_EVENTS, TIMER_INTERVAL); | ^ We do have a suppression, but not on the line preceding it, because we also need a cppcheck suppression there. Use NOLINTBEGIN/NOLINTEND for the clang-tidy suppression. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--passt.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/passt.c b/passt.c
index eaf231d..fac6101 100644
--- a/passt.c
+++ b/passt.c
@@ -309,9 +309,10 @@ int main(int argc, char **argv)
timer_init(&c, &now);
loop:
- /* NOLINTNEXTLINE(bugprone-branch-clone): intervals can be the same */
+ /* NOLINTBEGIN(bugprone-branch-clone): intervals can be the same */
/* cppcheck-suppress [duplicateValueTernary, unmatchedSuppression] */
nfds = epoll_wait(c.epollfd, events, EPOLL_EVENTS, TIMER_INTERVAL);
+ /* NOLINTEND(bugprone-branch-clone) */
if (nfds == -1 && errno != EINTR)
die_perror("epoll_wait() failed in main loop");