aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2022-10-11 00:36:30 +0200
committerStefano Brivio <sbrivio@redhat.com>2022-10-15 02:10:36 +0200
commit6acf89638bf29c9d2cfb782ec752b35a418e921b (patch)
tree5ab72d9cc540d8dfa277c681d3d2d9a6ac4d7872
parent6f3e38cac5c23dcd2dd6649132f0c55bac331f2e (diff)
downloadpasst-6acf89638bf29c9d2cfb782ec752b35a418e921b.tar
passt-6acf89638bf29c9d2cfb782ec752b35a418e921b.tar.gz
passt-6acf89638bf29c9d2cfb782ec752b35a418e921b.tar.bz2
passt-6acf89638bf29c9d2cfb782ec752b35a418e921b.tar.lz
passt-6acf89638bf29c9d2cfb782ec752b35a418e921b.tar.xz
passt-6acf89638bf29c9d2cfb782ec752b35a418e921b.tar.zst
passt-6acf89638bf29c9d2cfb782ec752b35a418e921b.zip
netlink: Disable duplicate address detection for configured IPv6 address
With default options, when we pass --config-net, the IPv6 address is actually going to be recycled from the init namespace, so it is in fact duplicated, but duplicate address detection has no way to find out. With a different configured address, that's not the case, but anyway duplicate address detection will be unable to see this. In both cases, we're wasting time for nothing. Pass the IFA_F_NODAD flag as we configure globally scoped IPv6 addresses via netlink. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--netlink.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/netlink.c b/netlink.c
index 9719e91..6e5a96b 100644
--- a/netlink.c
+++ b/netlink.c
@@ -343,6 +343,9 @@ void nl_addr(int ns, unsigned int ifi, sa_family_t af,
if (af == AF_INET6) {
size_t rta_len = RTA_LENGTH(sizeof(req.set.a6.l));
+ /* By default, strictly speaking, it's duplicated */
+ req.ifa.ifa_flags = IFA_F_NODAD;
+
req.nlh.nlmsg_len = offsetof(struct req_t, set.a6)
+ sizeof(req.set.a6);