aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2023-11-15 13:59:45 +1100
committerStefano Brivio <sbrivio@redhat.com>2023-11-19 09:08:18 +0100
commit3be9e0010ea7329ae0f3707f67ac4cf0bac13d54 (patch)
treef00b3e4e99f241a621af6e02b017abcbff832200
parent5ec3634b07215337c2e69d88f9b1d74711897d7d (diff)
downloadpasst-3be9e0010ea7329ae0f3707f67ac4cf0bac13d54.tar
passt-3be9e0010ea7329ae0f3707f67ac4cf0bac13d54.tar.gz
passt-3be9e0010ea7329ae0f3707f67ac4cf0bac13d54.tar.bz2
passt-3be9e0010ea7329ae0f3707f67ac4cf0bac13d54.tar.lz
passt-3be9e0010ea7329ae0f3707f67ac4cf0bac13d54.tar.xz
passt-3be9e0010ea7329ae0f3707f67ac4cf0bac13d54.tar.zst
passt-3be9e0010ea7329ae0f3707f67ac4cf0bac13d54.zip
clang-tidy: Suppress silly misc-include-cleaner warnings
clang-tidy from LLVM 17.0.3 (which is in Fedora 39) includes a new "misc-include-cleaner" warning that tries to make sure that headers *directly* provide the things that are used in the .c file. That sounds great in theory but is in practice unusable: Quite a few common things in the standard library are ultimately provided by OS-specific system headers, but for portability should be accessed via closer-to-standardised library headers. This will warn constantly about such cases: e.g. it will want you to include <linux/limits.h> instead of <limits.h> to get PATH_MAX. So, suppress this warning globally in the Makefile. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--Makefile9
1 files changed, 8 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 743c123..ff21459 100644
--- a/Makefile
+++ b/Makefile
@@ -250,6 +250,12 @@ docs: README.md
# - bugprone-assignment-in-if-condition
# Dubious value over the compiler's built-in warning. Would
# increase verbosity.
+#
+# - misc-include-cleaner
+# Wants to include headers which *directly* provide the things
+# we use. That sounds nice, but means it will often want a OS
+# specific header instead of a mostly standard one, such as
+# <linux/limits.h> instead of <limits.h>.
clang-tidy: $(SRCS) $(HEADERS)
clang-tidy -checks=*,-modernize-*,\
@@ -275,7 +281,8 @@ clang-tidy: $(SRCS) $(HEADERS)
-readability-function-cognitive-complexity,\
-altera-struct-pack-align,\
-concurrency-mt-unsafe,\
- -readability-identifier-length \
+ -readability-identifier-length,\
+ -misc-include-cleaner \
-config='{CheckOptions: [{key: bugprone-suspicious-string-compare.WarnOnImplicitComparison, value: "false"}]}' \
--warnings-as-errors=* $(SRCS) -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -DCLANG_TIDY_58992