aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2024-11-06 10:25:20 +1100
committerStefano Brivio <sbrivio@redhat.com>2024-11-07 12:46:29 +0100
commit30b4f8816774665321e6903b4f55a929b015d16d (patch)
tree112e355f20bea2c9d9250362c68fc4ddc2d3ca6f
parentb78e72da0b27e222592ff1f1578c69bad4756c65 (diff)
downloadpasst-30b4f8816774665321e6903b4f55a929b015d16d.tar
passt-30b4f8816774665321e6903b4f55a929b015d16d.tar.gz
passt-30b4f8816774665321e6903b4f55a929b015d16d.tar.bz2
passt-30b4f8816774665321e6903b4f55a929b015d16d.tar.lz
passt-30b4f8816774665321e6903b4f55a929b015d16d.tar.xz
passt-30b4f8816774665321e6903b4f55a929b015d16d.tar.zst
passt-30b4f8816774665321e6903b4f55a929b015d16d.zip
arch: Avoid explicit access to 'environ'
We pass 'environ' to execve() in arch_avc2_exec(), so that we retain the environment in the current process. But the declaration of 'environ' is a bit weird - it doesn't seem to be in a standard header, requiring a manual explicit declaration. But, we can avoid needing to reference it explicitly by using execv() instead of execve(). This removes a clang warning. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--arch.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch.c b/arch.c
index d1dfb73..e1ee729 100644
--- a/arch.c
+++ b/arch.c
@@ -45,7 +45,7 @@ void arch_avx2_exec(char **argv)
"%s.avx2", exe))
die_perror("Can't build AVX2 executable path");
- execve(new_path, argv, environ);
+ execv(new_path, argv);
warn_perror("Can't run AVX2 build, using non-AVX2 version");
}
}