aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorVolker Diels-Grabsch <v@njh.eu>2025-09-16 21:21:16 +0200
committerStefano Brivio <sbrivio@redhat.com>2025-09-17 13:52:41 +0200
commit1f22fde93466005d803bf2fb1b17147b877fb7ed (patch)
treedf33daeb232467f8061dc7b79e8e7aa5c2e40d92
parente2920e36f65f333af5d217933dc04f32947bb028 (diff)
downloadpasst-1f22fde93466005d803bf2fb1b17147b877fb7ed.tar
passt-1f22fde93466005d803bf2fb1b17147b877fb7ed.tar.gz
passt-1f22fde93466005d803bf2fb1b17147b877fb7ed.tar.bz2
passt-1f22fde93466005d803bf2fb1b17147b877fb7ed.tar.lz
passt-1f22fde93466005d803bf2fb1b17147b877fb7ed.tar.xz
passt-1f22fde93466005d803bf2fb1b17147b877fb7ed.tar.zst
passt-1f22fde93466005d803bf2fb1b17147b877fb7ed.zip
Improve clarity of commentHEADmaster
The new wording clarifies that we (1) use the broadcast MAC address only until we know the actual MAC address of the guest, and (2) our first packets will not necessarily "reach" the guest, in the sense of being processed rather than dropped. (Which is why we actively send an initial ARP and/or NDP message, to get the guest MAC address as soon as possible.) Signed-off-by: Volker Diels-Grabsch <v@njh.eu> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--tap.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tap.c b/tap.c
index 0f8ee25..399eeaa 100644
--- a/tap.c
+++ b/tap.c
@@ -1512,9 +1512,9 @@ void tap_backend_init(struct ctx *c)
case MODE_PASST:
tap_sock_unix_init(c);
- /* In passt mode, we don't know the guest's MAC address until it
- * sends us packets. Use the broadcast address so that our
- * first packets will reach it.
+ /* In passt mode, we don't know the guest's MAC address until
+ * it sends us packets. Until then, use the broadcast address
+ * so that our first packets will have a chance to reach it.
*/
memcpy(&c->guest_mac, MAC_BROADCAST, sizeof(c->guest_mac));
break;