aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2022-09-13 14:35:18 +1000
committerStefano Brivio <sbrivio@redhat.com>2022-09-13 11:12:41 +0200
commit1e4a15398f2f932e290ab222d2d57a47018f2245 (patch)
treed08ed73360af84ef0fd931713401d19bf7d7b612
parenta9b18300b477088696643db7cdbf3002d22dc9e2 (diff)
downloadpasst-1e4a15398f2f932e290ab222d2d57a47018f2245.tar
passt-1e4a15398f2f932e290ab222d2d57a47018f2245.tar.gz
passt-1e4a15398f2f932e290ab222d2d57a47018f2245.tar.bz2
passt-1e4a15398f2f932e290ab222d2d57a47018f2245.tar.lz
passt-1e4a15398f2f932e290ab222d2d57a47018f2245.tar.xz
passt-1e4a15398f2f932e290ab222d2d57a47018f2245.tar.zst
passt-1e4a15398f2f932e290ab222d2d57a47018f2245.zip
test: Actually run cleanup function
We install a cleanup() function with 'trap' in order to clean up temporary files we generate during the tests. However, we deinstall it after run_term, which means it won't run in most of the cases where it would be useful. Even if "run from_term" exits with an error, that error will be hidden from the run_term wrapper because it's within a tmux session, so we will return from run_term normally, uninstall the trap and never clean up. In fact there's no reason to uninstall the trap at all, it works just as well on the success exit path as an error exit path. Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
-rwxr-xr-xtest/run1
1 files changed, 0 insertions, 1 deletions
diff --git a/test/run b/test/run
index d8b60bf..9b0227b 100755
--- a/test/run
+++ b/test/run
@@ -178,7 +178,6 @@ else
:> "${LOGFILE}"
trap "cleanup" EXIT
run_term
- trap "" EXIT
fi
[ ${DEMO} -eq 1 ] && exit 0