aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2026-05-20 12:00:55 +1000
committerStefano Brivio <sbrivio@redhat.com>2026-05-26 12:15:44 +0200
commitcea2d19329eb0088a738c60b92ddc06dcf50a4cd (patch)
tree100aa549534b0fb11942684b54a183ca67968a48
parent5038f925b028f2faa401b3210327c1de1a24e84b (diff)
downloadpasst-cea2d19329eb0088a738c60b92ddc06dcf50a4cd.tar
passt-cea2d19329eb0088a738c60b92ddc06dcf50a4cd.tar.gz
passt-cea2d19329eb0088a738c60b92ddc06dcf50a4cd.tar.bz2
passt-cea2d19329eb0088a738c60b92ddc06dcf50a4cd.tar.lz
passt-cea2d19329eb0088a738c60b92ddc06dcf50a4cd.tar.xz
passt-cea2d19329eb0088a738c60b92ddc06dcf50a4cd.tar.zst
passt-cea2d19329eb0088a738c60b92ddc06dcf50a4cd.zip
Makefile: Remove misleading comments on BASE_*FLAGS
I added these comments attempting to describe the difference between BASE_CFLAGS and CFLAGS. However, the description given isn't really accurate, and I'm not even sure the concept I'm trying to describe is coherent. Just remove it. Suggested-by: Stefano Brivio <sbrivio@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--Makefile4
1 files changed, 0 insertions, 4 deletions
diff --git a/Makefile b/Makefile
index c4af57b..0a0a60b 100644
--- a/Makefile
+++ b/Makefile
@@ -30,15 +30,11 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > /
FORTIFY_FLAG := -D_FORTIFY_SOURCE=2
endif
-# Mandatory preprocessor flags that won't be overridden with $(CPPFLAGS)
-# FIXME: Could some of these be default, rather than required?
BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE $(FORTIFY_FLAG)
BASE_CPPFLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE)
BASE_CPPFLAGS += -DVERSION=\"$(VERSION)\"
BASE_CPPFLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS)
-# Mandatory compiler flags that won't be overridden with $(CFLAGS)
-# FIXME: Could some of these be default, rather than required?
BASE_CFLAGS := -std=c11 -pie -fPIE -O2
BASE_CFLAGS += -pedantic -Wall -Wextra -Wno-format-zero-length -Wformat-security