From 627e18fa8ad000ed92405cff3a88c36fd5f3027e Mon Sep 17 00:00:00 2001
From: Stefano Brivio <sbrivio@redhat.com>
Date: Thu, 21 Oct 2021 09:41:13 +0200
Subject: passt: Add cppcheck target, test, and address resulting warnings

...mostly false positives, but a number of very relevant ones too,
in tcp_get_sndbuf(), tcp_conn_from_tap(), and siphash PREAMBLE().

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 util.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'util.c')

diff --git a/util.c b/util.c
index 5ecb43a..3c4ba33 100644
--- a/util.c
+++ b/util.c
@@ -51,7 +51,7 @@ void name(const char *format, ...) {					\
 									\
 	if (setlogmask(0) & LOG_MASK(LOG_DEBUG)) {			\
 		clock_gettime(CLOCK_REALTIME, &tp);			\
-		fprintf(stderr, "%lu.%04lu: ",				\
+		fprintf(stderr, "%li.%04li: ",				\
 			tp.tv_sec - log_debug_start,			\
 			tp.tv_nsec / (100 * 1000));			\
 	} else {							\
@@ -142,7 +142,7 @@ void passt_vsyslog(int pri, const char *format, va_list ap)
 	if (format[strlen(format)] != '\n')
 		n += snprintf(buf + n, BUFSIZ - n, "\n");
 
-	if (log_opt | LOG_PERROR)
+	if (log_opt & LOG_PERROR)
 		fprintf(stderr, "%s", buf + sizeof("<0>"));
 
 	send(log_sock, buf, n, 0);
-- 
cgit v1.2.3