From 14fe73e766206c71ab3c6d5ddc252435c36423bd Mon Sep 17 00:00:00 2001 From: Stefan Hajnoczi Date: Fri, 15 Oct 2021 11:27:17 +0100 Subject: udp: drop bogus udp_tap_map ts assignment The 'ts' field is a timestamp so assigning the socket file descriptor is incorrect. There is no actual bug because the current time is assigned just a few lines later: udp_tap_map[V4][src].sock = s; udp_tap_map[V4][src].ts = s; ^^^^^^^^^^^ bogus ^^^^^^^^^^ bitmap_set(udp_act[V4][UDP_ACT_TAP], src); } udp_tap_map[V4][src].ts = now->tv_sec; ^^^^^^^^^^^^^^^ correct ^^^^^^^^^^^^^^ Signed-off-by: Stefan Hajnoczi Signed-off-by: Stefano Brivio --- udp.c | 1 - 1 file changed, 1 deletion(-) (limited to 'udp.c') diff --git a/udp.c b/udp.c index 148b06a..ceb10a6 100644 --- a/udp.c +++ b/udp.c @@ -927,7 +927,6 @@ int udp_tap_handler(struct ctx *c, int af, void *addr, return count; udp_tap_map[V4][src].sock = s; - udp_tap_map[V4][src].ts = s; bitmap_set(udp_act[V4][UDP_ACT_TAP], src); } -- cgit v1.2.3