From e5e10aff8179b5f410b4e2fe7923303fd183fc75 Mon Sep 17 00:00:00 2001
From: David Gibson <david@gibson.dropbear.id.au>
Date: Fri, 2 Sep 2022 12:04:34 +1000
Subject: test: Rewrite test_iperf3
test_iperf3() is a pretty inscrutable mess of nested background processes.
It has a number of ugly sleeps needed to wait for things to complete.
Rewrite it to be cleaner:
* Use the construct (a & b & wait) to run 'a' and 'b' in parallel, but
then wait for them both to complete before continuing
* This allows us to wait for both the server and client to finish, rather
than sleeping
* Use jq to do all the math we need to get the final result, rather than
jq followed by some complicated 'bc' mangling
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
test/perf/passt_tcp | 4 ++--
test/perf/pasta_tcp | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
(limited to 'test/perf')
diff --git a/test/perf/passt_tcp b/test/perf/passt_tcp
index a960341..45095b6 100644
--- a/test/perf/passt_tcp
+++ b/test/perf/passt_tcp
@@ -11,8 +11,8 @@
# Copyright (c) 2021 Red Hat GmbH
# Author: Stefano Brivio <sbrivio@redhat.com>
-gtools sysctl ip jq nproc seq sleep bc iperf3 tcp_rr tcp_crr # From neper
-nstools sysctl ip jq nproc seq sleep bc iperf3 tcp_rr tcp_crr
+gtools sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr # From neper
+nstools sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr
htools bc head sed seq
# In this setup, virtio_net TX queue sometimes hangs, still under investigation
diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp
index 8866253..4c19364 100644
--- a/test/perf/pasta_tcp
+++ b/test/perf/pasta_tcp
@@ -12,7 +12,7 @@
# Author: Stefano Brivio <sbrivio@redhat.com>
htools head ip seq bc sleep iperf3 tcp_rr tcp_crr jq sed
-nstools sysctl nproc ip seq bc sleep iperf3 tcp_rr tcp_crr jq sed
+nstools sysctl nproc ip seq sleep iperf3 tcp_rr tcp_crr jq sed
test pasta: throughput and latency (local connections)
--
cgit v1.2.3