From ca0c33ae5b8a68806dd1c766e2f58ce24867f334 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Fri, 10 Jun 2022 12:32:43 +1000 Subject: Tweak dhclient arguments for readability A number of tests and examples use dhclient in both IPv4 and IPv6 modes. We use "dhclient -6" for IPv6, but usually just "dhclient" for IPv4. Add an explicit "-4" argument to make it more clear and explicit. In addition, when dhclient is run from within pasta it usually won't be "real" root, and so will not have access to write the default global pid file. This results in a mostly harmless but irritating error: Can't create /var/run/dhclient.pid: Permission denied We can avoid that by using the --no-pid flag to dhclient. Signed-off-by: David Gibson --- test/lib/setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/lib/setup') diff --git a/test/lib/setup b/test/lib/setup index ffc4171..32515bf 100755 --- a/test/lib/setup +++ b/test/lib/setup @@ -147,7 +147,7 @@ setup_passt_in_ns() { pane_run NS "/sbin/udhcpc -i ${__ifname}" pane_status NS sleep 2 - pane_run NS "/sbin/dhclient -6 ${__ifname}" + pane_run NS "/sbin/dhclient -6 --no-pid ${__ifname}" pane_status NS __opts= -- cgit v1.2.3