From 7ecf6932978786910f510beff99afcbf507645ff Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Thu, 16 Sep 2021 08:24:00 +0200 Subject: pasta, tcp: Don't set TCP_CORK on spliced sockets ...throughput isn't everything: this leads (of course) to horrible latency with small, sparse messages. As a consequence, there's no need to set TCP_NODELAY either. Signed-off-by: Stefano Brivio --- tcp.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'tcp.c') diff --git a/tcp.c b/tcp.c index 1ad1050..b398bbe 100644 --- a/tcp.c +++ b/tcp.c @@ -2380,19 +2380,14 @@ static int tcp_splice_connect(struct ctx *c, struct tcp_splice_conn *conn, .sin_addr = { .s_addr = htonl(INADDR_LOOPBACK) }, }; const struct sockaddr *sa; - int ret, one = 1; socklen_t sl; + int ret; if (sock_conn < 0) return -errno; conn->to = sock_conn; - setsockopt(conn->from, SOL_TCP, TCP_CORK, &one, sizeof(one)); - setsockopt(conn->from, SOL_TCP, TCP_NODELAY, &one, sizeof(one)); - setsockopt(conn->to, SOL_TCP, TCP_CORK, &one, sizeof(one)); - setsockopt(conn->to, SOL_TCP, TCP_NODELAY, &one, sizeof(one)); - if (v6) { sa = (struct sockaddr *)&addr6; sl = sizeof(addr6); -- cgit v1.2.3