From fb5d1c5d7d0b914a90aaeecf406c7092d9d55aeb Mon Sep 17 00:00:00 2001 From: David Gibson Date: Wed, 19 Oct 2022 11:43:51 +1100 Subject: tap: Remove unhelpeful vnet_pre optimization from tap_send() Callers of tap_send() can optionally use a small optimization by adding extra space for the 4 byte length header used on the qemu socket interface. tap_ip_send() is currently the only user of this, but this is used only for "slow path" ICMP and DHCP packets, so there's not a lot of value to the optimization. Worse, having the two paths here complicates the interface and makes future cleanups difficult, so just remove it. I have some plans to bring back the optimization in a more general way in future, but for now it's just in the way. Signed-off-by: David Gibson Signed-off-by: Stefano Brivio --- tap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tap.h') diff --git a/tap.h b/tap.h index a6764b4..a8da8bb 100644 --- a/tap.h +++ b/tap.h @@ -11,7 +11,7 @@ const struct in6_addr *tap_ip6_daddr(const struct ctx *c, const struct in6_addr *src); void tap_ip_send(const struct ctx *c, const struct in6_addr *src, uint8_t proto, const char *in, size_t len, uint32_t flow); -int tap_send(const struct ctx *c, const void *data, size_t len, int vnet_pre); +int tap_send(const struct ctx *c, const void *data, size_t len); void tap_handler(struct ctx *c, int fd, uint32_t events, const struct timespec *now); void tap_sock_init(struct ctx *c); -- cgit v1.2.3