From bd7340e815814736fd4effdf2fed5452d9e17c23 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Sat, 26 Feb 2022 23:32:50 +0100 Subject: tap: Cast ETH_MAX_MTU to signed in comparisons At least gcc 8.3 and 10.2 emit a warning on armv6l and armv7l. Signed-off-by: Stefano Brivio --- tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tap.c') diff --git a/tap.c b/tap.c index 9e6ece9..29fcd51 100644 --- a/tap.c +++ b/tap.c @@ -658,7 +658,7 @@ redo: /* Complete the partial read above before discarding a malformed * frame, otherwise the stream will be inconsistent. */ - if (len < (ssize_t)sizeof(*eh) || len > ETH_MAX_MTU) + if (len < (ssize_t)sizeof(*eh) || len > (ssize_t)ETH_MAX_MTU) goto next; pcap(p, len); @@ -718,7 +718,7 @@ restart: while ((len = read(c->fd_tap, pkt_buf + n, TAP_BUF_BYTES - n)) > 0) { struct ethhdr *eh = (struct ethhdr *)(pkt_buf + n); - if (len < (ssize_t)sizeof(*eh) || len > ETH_MAX_MTU) { + if (len < (ssize_t)sizeof(*eh) || len > (ssize_t)ETH_MAX_MTU) { n += len; continue; } -- cgit v1.2.3