From 1095a7b0c9a150cb488ff5bd5fd74c897dd9236e Mon Sep 17 00:00:00 2001 From: David Gibson Date: Wed, 1 May 2024 16:53:47 +1000 Subject: treewide: Remove misleading and redundant endianness notes In general, it's much less error-prone to have the endianness of values implied by the type, rather than just noting it in comments. We can't always easily avoid it, because C, but we can do so when possible. struct in_addr and in6_addr are always encoded network endian, so noting it explicitly isn't useful. Remove them. In some cases we also have endianness notes on uint8_t parameters, which doesn't make sense: for a single byte endianness is irrelevant. Remove those too. Signed-off-by: David Gibson Signed-off-by: Stefano Brivio --- tap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tap.c') diff --git a/tap.c b/tap.c index 13e4da7..d0ef6b5 100644 --- a/tap.c +++ b/tap.c @@ -95,7 +95,7 @@ void tap_send_single(const struct ctx *c, const void *data, size_t len) * tap_ip4_daddr() - Normal IPv4 destination address for inbound packets * @c: Execution context * - * Return: IPv4 address, network order + * Return: IPv4 address */ struct in_addr tap_ip4_daddr(const struct ctx *c) { @@ -139,8 +139,8 @@ static void *tap_push_l2h(const struct ctx *c, void *buf, uint16_t proto) /** * tap_push_ip4h() - Build IPv4 header for inbound packet, with checksum * @c: Execution context - * @src: IPv4 source address, network order - * @dst: IPv4 destination address, network order + * @src: IPv4 source address + * @dst: IPv4 destination address * @len: L4 payload length * @proto: L4 protocol number * -- cgit v1.2.3