From 0d547a5b0f0bcb3c98f0323adbe4b9fc242ed6a1 Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Fri, 24 Feb 2023 19:49:49 +0100 Subject: qrap: Generate -netdev as JSON While generating -device as JSON when JSON is in use is mandatory, because not doing so can often prevent the VM from starting up, using JSON for -netdev simply makes things a bit nicer. No reason not to do it, though. Signed-off-by: Andrea Bolognani Reviewed-by: David Gibson --- qrap.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'qrap.c') diff --git a/qrap.c b/qrap.c index 27c12ed..d0e2fb2 100644 --- a/qrap.c +++ b/qrap.c @@ -311,7 +311,11 @@ int main(int argc, char **argv) } qemu_argv[qemu_argc++] = "-netdev"; - qemu_argv[qemu_argc++] = "socket,fd=" STR(DEFAULT_FD) ",id=hostnet0"; + if (!has_json) { + qemu_argv[qemu_argc++] = "socket,fd=" STR(DEFAULT_FD) ",id=hostnet0"; + } else { + qemu_argv[qemu_argc++] = "{\"type\":\"socket\",\"fd\":\"" STR(DEFAULT_FD) "\",\"id\":\"hostnet0\"}"; + } qemu_argv[qemu_argc] = NULL; valid_args: -- cgit v1.2.3