From dba7f0f5cee06dcfc205b0284ba19c2651f594c4 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Mon, 17 Jun 2024 11:55:04 +0200 Subject: treewide: Replace strerror() calls Now that we have logging functions embedding perror() functionality, we can make _some_ calls more terse by using them. In many places, the strerror() calls are still more convenient because, for example, they are used in flow debugging functions, or because the return code variable of interest is not 'errno'. While at it, convert a few error messages from a scant perror style to proper failure descriptions. Signed-off-by: Stefano Brivio Reviewed-by: David Gibson --- passt.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'passt.c') diff --git a/passt.c b/passt.c index a48c5f6..13f3eb6 100644 --- a/passt.c +++ b/passt.c @@ -227,15 +227,11 @@ int main(int argc, char **argv) __openlog("pasta", 0, LOG_DAEMON); sa.sa_handler = pasta_child_handler; - if (sigaction(SIGCHLD, &sa, NULL)) { - die("Couldn't install signal handlers: %s", - strerror(errno)); - } + if (sigaction(SIGCHLD, &sa, NULL)) + die_perror("Couldn't install signal handlers"); - if (signal(SIGPIPE, SIG_IGN) == SIG_ERR) { - die("Couldn't set disposition for SIGPIPE: %s", - strerror(errno)); - } + if (signal(SIGPIPE, SIG_IGN) == SIG_ERR) + die_perror("Couldn't set disposition for SIGPIPE"); c.mode = MODE_PASTA; } else if (strstr(name, "passt")) { -- cgit v1.2.3