From 627e18fa8ad000ed92405cff3a88c36fd5f3027e Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Thu, 21 Oct 2021 09:41:13 +0200 Subject: passt: Add cppcheck target, test, and address resulting warnings ...mostly false positives, but a number of very relevant ones too, in tcp_get_sndbuf(), tcp_conn_from_tap(), and siphash PREAMBLE(). Signed-off-by: Stefano Brivio --- ndp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'ndp.c') diff --git a/ndp.c b/ndp.c index 5fa2bff..3a766ec 100644 --- a/ndp.c +++ b/ndp.c @@ -91,7 +91,7 @@ int ndp(struct ctx *c, struct ethhdr *eh, size_t len) memcpy(p, c->mac, ETH_ALEN); p += 6; } else if (ih->icmp6_type == RS) { - size_t len = 0; + size_t dns_s_len = 0; int i, n; if (c->no_ra) @@ -139,7 +139,7 @@ int ndp(struct ctx *c, struct ethhdr *eh, size_t len) } for (n = 0; *c->dns_search[n].n; n++) - len += strlen(c->dns_search[n].n) + 2; + dns_s_len += strlen(c->dns_search[n].n) + 2; if (len) { *p++ = 31; /* DNSSL */ *p++ = (len + 8 - 1) / 8 + 1; /* length */ @@ -163,8 +163,8 @@ int ndp(struct ctx *c, struct ethhdr *eh, size_t len) *(p++) = 0; } - memset(p, 0, 8 - len % 8); /* padding */ - p += 8 - len % 8; + memset(p, 0, 8 - dns_s_len % 8); /* padding */ + p += 8 - dns_s_len % 8; } *p++ = 1; /* source ll */ -- cgit v1.2.3