From e46f67f15230e07ef35f4f54126a47ef5a60238b Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Tue, 5 Apr 2022 11:55:35 +0200 Subject: conf: False "Assign instead of compare" positive, CWE-481 This really just needs to be an assignment before line_read() -- turn it into a for loop. Reported by Coverity. Signed-off-by: Stefano Brivio --- conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'conf.c') diff --git a/conf.c b/conf.c index ca44b30..2412fc6 100644 --- a/conf.c +++ b/conf.c @@ -288,7 +288,7 @@ static void get_dns(struct ctx *c) if ((fd = open("/etc/resolv.conf", O_RDONLY | O_CLOEXEC)) < 0) goto out; - while (!(*buf = 0) && line_read(buf, BUFSIZ, fd)) { + for (*buf = 0; line_read(buf, BUFSIZ, fd); *buf = 0) { if (!dns_set && strstr(buf, "nameserver ") == buf) { p = strrchr(buf, ' '); if (!p) -- cgit v1.2.3