From 0786b2e60a71c94b4243224d01a810a4a52b8b72 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Tue, 5 Apr 2022 07:24:48 +0200 Subject: conf, packet: Operands don't affect result, CWE-569 Reported by Coverity. Signed-off-by: Stefano Brivio --- conf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'conf.c') diff --git a/conf.c b/conf.c index ea51de4..ca44b30 100644 --- a/conf.c +++ b/conf.c @@ -369,6 +369,7 @@ static int conf_ns_opt(struct ctx *c, int ufd = -1, nfd = -1, try, ret, netns_only_reset = c->netns_only; char userns[PATH_MAX] = { 0 }, netns[PATH_MAX]; char *endptr; + long pid_arg; pid_t pid; if (c->netns_only && *conf_userns) { @@ -379,10 +380,12 @@ static int conf_ns_opt(struct ctx *c, /* It might be a PID, a netns path, or a netns name */ for (try = 0; try < 3; try++) { if (try == 0) { - pid = strtol(optarg, &endptr, 10); - if (*endptr || pid > INT_MAX) + pid_arg = strtol(optarg, &endptr, 10); + if (*endptr || pid_arg < 0 || pid_arg > INT_MAX) continue; + pid = pid_arg; + if (!*conf_userns && !c->netns_only) { ret = snprintf(userns, PATH_MAX, "/proc/%i/ns/user", pid); -- cgit v1.2.3