From 627e18fa8ad000ed92405cff3a88c36fd5f3027e Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Thu, 21 Oct 2021 09:41:13 +0200 Subject: passt: Add cppcheck target, test, and address resulting warnings ...mostly false positives, but a number of very relevant ones too, in tcp_get_sndbuf(), tcp_conn_from_tap(), and siphash PREAMBLE(). Signed-off-by: Stefano Brivio --- checksum.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'checksum.c') diff --git a/checksum.c b/checksum.c index dcbe905..c9905d1 100644 --- a/checksum.c +++ b/checksum.c @@ -167,8 +167,8 @@ static uint32_t csum_avx2(const void *buf, size_t len, uint32_t init) { __m256i a, b, sum256, sum_a_hi, sum_a_lo, sum_b_hi, sum_b_lo, c, d; __m256i __sum_a_hi, __sum_a_lo, __sum_b_hi, __sum_b_lo; - const uint64_t *buf64 = (const uint64_t *)buf; - const __m256i *buf256; + const __m256i *buf256 = (const __m256i *)buf; + const uint64_t *buf64; const uint16_t *buf16; uint64_t sum64 = init; int odd = len & 1; @@ -176,7 +176,6 @@ static uint32_t csum_avx2(const void *buf, size_t len, uint32_t init) __m256i zero; zero = _mm256_setzero_si256(); - buf256 = (const __m256i *)buf64; if (len < sizeof(__m256i) * 4) goto less_than_128_bytes; @@ -267,7 +266,6 @@ static uint32_t csum_avx2(const void *buf, size_t len, uint32_t init) /* Fold 128-bit sum into 64 bits. */ sum64 += _mm_extract_epi64(sum128, 0) + _mm_extract_epi64(sum128, 1); - buf64 = (const uint64_t *)buf256; less_than_128_bytes: for (; len >= sizeof(a); len -= sizeof(a), buf256++) { -- cgit v1.2.3