From ffbef85e975ba117ed1c20f733d989ac08ebf325 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Tue, 8 Apr 2025 07:57:51 +0200 Subject: conf: Add missing return in conf_nat(), fix --map-guest-addr none As reported by somebody on IRC: $ pasta --map-guest-addr none Invalid address to remap to host: none that's because once we parsed "none", we try to parse it as an address as well. But we already handled it, so stop once we're done. Fixes: e813a4df7da2 ("conf: Allow address remapped to host to be configured") Signed-off-by: Stefano Brivio Reviewed-by: David Gibson --- conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/conf.c b/conf.c index b54c55d..168646f 100644 --- a/conf.c +++ b/conf.c @@ -1272,6 +1272,8 @@ static void conf_nat(const char *arg, struct in_addr *addr4, *addr6 = in6addr_any; if (no_map_gw) *no_map_gw = 1; + + return; } if (inet_pton(AF_INET6, arg, addr6) && -- cgit v1.2.3