From f9ee749cbb9bb1b962b37d6fd4655683b9953c13 Mon Sep 17 00:00:00 2001 From: Volker Diels-Grabsch Date: Sat, 6 Sep 2025 01:56:18 +0200 Subject: Add missing explicit PSH assignment For packets with data, we set the PSH flag depending on whether it's the last chunk of data in a single receive operation from a socket. But then we reuse the same buffers for SYN segments, and oops, PSH is set randomly. This change cleans this up by setting PSH explicitly, just as we do with the other flags. Signed-off-by: Volker Diels-Grabsch Signed-off-by: Stefano Brivio --- tcp.c | 1 + tcp_internal.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tcp.c b/tcp.c index dba5fdc..a27b069 100644 --- a/tcp.c +++ b/tcp.c @@ -1176,6 +1176,7 @@ int tcp_prepare_flags(const struct ctx *c, struct tcp_tap_conn *conn, th->doff = (sizeof(*th) + *optlen) / 4; th->ack = !!(flags & ACK); + th->psh = !!(flags & PSH); th->rst = !!(flags & RST); th->syn = !!(flags & SYN); th->fin = !!(flags & FIN); diff --git a/tcp_internal.h b/tcp_internal.h index 36c6533..9dae688 100644 --- a/tcp_internal.h +++ b/tcp_internal.h @@ -26,6 +26,7 @@ #define FIN (1 << 0) #define SYN (1 << 1) #define RST (1 << 2) +#define PSH (1 << 3) #define ACK (1 << 4) /* Flags for internal usage */ -- cgit v1.2.3