From ed187c353dffb0362941e1612d41307e7bff1783 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Fri, 27 Mar 2026 15:34:26 +1100 Subject: conf: Remove redundant warning when SO_BINDTODEVICE is unavailable conf_ports() has logic to warn if -[TU] auto is specified but we can't use SO_BINDTODEVICE. However, this is redundant with similar logic in conf_ports_range_except(). The latter will be triggered both for an explicit -[TU] auto and when it's invoked as a default option, so keep that one and drop the one in conf_ports(). Signed-off-by: David Gibson Signed-off-by: Stefano Brivio --- conf.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/conf.c b/conf.c index d4c2a01..5639ef0 100644 --- a/conf.c +++ b/conf.c @@ -249,12 +249,6 @@ static void conf_ports(const struct ctx *c, char optname, const char *optarg, if (c->mode != MODE_PASTA) die("'auto' port forwarding is only allowed for pasta"); - if ((optname == 'T' || optname == 'U') && c->no_bindtodevice) { - warn( -"'-%c auto' enabled without unprivileged SO_BINDTODEVICE", optname); - warn( -"Forwarding from addresses other than 127.0.0.1 will not work"); - } *mode = FWD_MODE_AUTO; return; } -- cgit v1.2.3